-
Notifications
You must be signed in to change notification settings - Fork 324
Avoid final field mutation in CapturedSnapshotTest #10440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d65bf18 to
d88e1b4
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (305.685 µs) : 281, 330
. : milestone, 306,
basic (275.964 µs) : 268, 284
. : milestone, 276,
loop (8.956 ms) : 8952, 8961
. : milestone, 8956,
section candidate
noprobe (321.28 µs) : 284, 358
. : milestone, 321,
basic (276.276 µs) : 270, 283
. : milestone, 276,
loop (8.955 ms) : 8949, 8961
. : milestone, 8955,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059871
Total [baseline] (8.774 s) : 0, 8773539
Agent [candidate] (1.059 s) : 0, 1058545
Total [candidate] (8.714 s) : 0, 8714462
section iast
Agent [baseline] (1.226 s) : 0, 1226407
Total [baseline] (9.4 s) : 0, 9400162
Agent [candidate] (1.234 s) : 0, 1233877
Total [candidate] (9.418 s) : 0, 9417999
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (627.356 ms) : 0, 627356
BytebuddyAgent [candidate] (624.004 ms) : 0, 624004
AgentMeter [baseline] (28.886 ms) : 0, 28886
AgentMeter [candidate] (28.676 ms) : 0, 28676
GlobalTracer [baseline] (257.449 ms) : 0, 257449
GlobalTracer [candidate] (257.004 ms) : 0, 257004
AppSec [baseline] (32.677 ms) : 0, 32677
AppSec [candidate] (32.996 ms) : 0, 32996
Debugger [baseline] (60.933 ms) : 0, 60933
Debugger [candidate] (60.202 ms) : 0, 60202
Remote Config [baseline] (608.24 µs) : 0, 608
Remote Config [candidate] (614.922 µs) : 0, 615
Telemetry [baseline] (9.149 ms) : 0, 9149
Telemetry [candidate] (9.98 ms) : 0, 9980
Flare Poller [baseline] (6.155 ms) : 0, 6155
Flare Poller [candidate] (8.443 ms) : 0, 8443
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (791.547 ms) : 0, 791547
BytebuddyAgent [candidate] (796.584 ms) : 0, 796584
AgentMeter [baseline] (11.218 ms) : 0, 11218
AgentMeter [candidate] (11.422 ms) : 0, 11422
GlobalTracer [baseline] (247.996 ms) : 0, 247996
GlobalTracer [candidate] (249.576 ms) : 0, 249576
AppSec [baseline] (32.124 ms) : 0, 32124
AppSec [candidate] (34.771 ms) : 0, 34771
Debugger [baseline] (67.642 ms) : 0, 67642
Debugger [candidate] (65.059 ms) : 0, 65059
Remote Config [baseline] (541.578 µs) : 0, 542
Remote Config [candidate] (554.944 µs) : 0, 555
Telemetry [baseline] (8.511 ms) : 0, 8511
Telemetry [candidate] (8.609 ms) : 0, 8609
Flare Poller [baseline] (3.462 ms) : 0, 3462
Flare Poller [candidate] (3.526 ms) : 0, 3526
IAST [baseline] (26.785 ms) : 0, 26785
IAST [candidate] (27.08 ms) : 0, 27080
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055739
Total [baseline] (10.932 s) : 0, 10932184
Agent [candidate] (1.062 s) : 0, 1061966
Total [candidate] (11.035 s) : 0, 11034867
section appsec
Agent [baseline] (1.231 s) : 0, 1230896
Total [baseline] (10.973 s) : 0, 10972709
Agent [candidate] (1.232 s) : 0, 1231761
Total [candidate] (11.049 s) : 0, 11048624
section iast
Agent [baseline] (1.228 s) : 0, 1227692
Total [baseline] (11.178 s) : 0, 11178116
Agent [candidate] (1.23 s) : 0, 1229872
Total [candidate] (11.179 s) : 0, 11178704
section profiling
Agent [baseline] (1.185 s) : 0, 1185004
Total [baseline] (11.057 s) : 0, 11056728
Agent [candidate] (1.186 s) : 0, 1186315
Total [candidate] (10.919 s) : 0, 10919352
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (622.151 ms) : 0, 622151
BytebuddyAgent [candidate] (624.894 ms) : 0, 624894
AgentMeter [baseline] (28.691 ms) : 0, 28691
AgentMeter [candidate] (28.865 ms) : 0, 28865
GlobalTracer [baseline] (256.22 ms) : 0, 256220
GlobalTracer [candidate] (258.133 ms) : 0, 258133
AppSec [baseline] (32.798 ms) : 0, 32798
AppSec [candidate] (32.872 ms) : 0, 32872
Debugger [baseline] (60.964 ms) : 0, 60964
Debugger [candidate] (61.38 ms) : 0, 61380
Remote Config [baseline] (617.633 µs) : 0, 618
Remote Config [candidate] (614.998 µs) : 0, 615
Telemetry [baseline] (11.473 ms) : 0, 11473
Telemetry [candidate] (10.006 ms) : 0, 10006
Flare Poller [baseline] (6.214 ms) : 0, 6214
Flare Poller [candidate] (8.582 ms) : 0, 8582
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (652.545 ms) : 0, 652545
BytebuddyAgent [candidate] (652.103 ms) : 0, 652103
AgentMeter [baseline] (11.806 ms) : 0, 11806
AgentMeter [candidate] (11.861 ms) : 0, 11861
GlobalTracer [baseline] (257.152 ms) : 0, 257152
GlobalTracer [candidate] (257.303 ms) : 0, 257303
IAST [baseline] (25.3 ms) : 0, 25300
IAST [candidate] (25.196 ms) : 0, 25196
AppSec [baseline] (166.707 ms) : 0, 166707
AppSec [candidate] (167.382 ms) : 0, 167382
Debugger [baseline] (67.543 ms) : 0, 67543
Debugger [candidate] (67.876 ms) : 0, 67876
Remote Config [baseline] (655.989 µs) : 0, 656
Remote Config [candidate] (675.525 µs) : 0, 676
Telemetry [baseline] (9.281 ms) : 0, 9281
Telemetry [candidate] (9.3 ms) : 0, 9300
Flare Poller [baseline] (3.555 ms) : 0, 3555
Flare Poller [candidate] (3.619 ms) : 0, 3619
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (791.447 ms) : 0, 791447
BytebuddyAgent [candidate] (792.938 ms) : 0, 792938
AgentMeter [baseline] (11.184 ms) : 0, 11184
AgentMeter [candidate] (11.229 ms) : 0, 11229
GlobalTracer [baseline] (248.23 ms) : 0, 248230
GlobalTracer [candidate] (248.944 ms) : 0, 248944
IAST [baseline] (26.818 ms) : 0, 26818
IAST [candidate] (26.841 ms) : 0, 26841
AppSec [baseline] (34.735 ms) : 0, 34735
AppSec [candidate] (34.806 ms) : 0, 34806
Debugger [baseline] (66.2 ms) : 0, 66200
Debugger [candidate] (65.906 ms) : 0, 65906
Remote Config [baseline] (548.184 µs) : 0, 548
Remote Config [candidate] (544.743 µs) : 0, 545
Telemetry [baseline] (8.553 ms) : 0, 8553
Telemetry [candidate] (8.622 ms) : 0, 8622
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.54 ms) : 0, 3540
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (675.649 ms) : 0, 675649
BytebuddyAgent [candidate] (678.044 ms) : 0, 678044
AgentMeter [baseline] (8.589 ms) : 0, 8589
AgentMeter [candidate] (8.675 ms) : 0, 8675
GlobalTracer [baseline] (217.399 ms) : 0, 217399
GlobalTracer [candidate] (216.891 ms) : 0, 216891
AppSec [baseline] (32.5 ms) : 0, 32500
AppSec [candidate] (32.281 ms) : 0, 32281
Debugger [baseline] (67.893 ms) : 0, 67893
Debugger [candidate] (67.642 ms) : 0, 67642
Remote Config [baseline] (594.648 µs) : 0, 595
Remote Config [candidate] (587.468 µs) : 0, 587
Telemetry [baseline] (8.738 ms) : 0, 8738
Telemetry [candidate] (8.673 ms) : 0, 8673
Flare Poller [baseline] (3.795 ms) : 0, 3795
Flare Poller [candidate] (3.78 ms) : 0, 3780
ProfilingAgent [baseline] (98.571 ms) : 0, 98571
ProfilingAgent [candidate] (98.654 ms) : 0, 98654
Profiling [baseline] (99.128 ms) : 0, 99128
Profiling [candidate] (99.222 ms) : 0, 99222
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (17.531 ms) : 17358, 17704
. : milestone, 17531,
appsec (18.78 ms) : 18588, 18972
. : milestone, 18780,
code_origins (17.871 ms) : 17693, 18050
. : milestone, 17871,
iast (17.658 ms) : 17483, 17833
. : milestone, 17658,
profiling (18.603 ms) : 18413, 18793
. : milestone, 18603,
tracing (17.673 ms) : 17495, 17850
. : milestone, 17673,
section candidate
no_agent (19.153 ms) : 18955, 19351
. : milestone, 19153,
appsec (18.766 ms) : 18571, 18961
. : milestone, 18766,
code_origins (17.81 ms) : 17630, 17991
. : milestone, 17810,
iast (17.535 ms) : 17360, 17710
. : milestone, 17535,
profiling (18.552 ms) : 18364, 18739
. : milestone, 18552,
tracing (17.771 ms) : 17594, 17949
. : milestone, 17771,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1199
. : milestone, 1188,
iast (3.118 ms) : 3078, 3159
. : milestone, 3118,
iast_FULL (5.853 ms) : 5795, 5912
. : milestone, 5853,
iast_GLOBAL (3.626 ms) : 3569, 3683
. : milestone, 3626,
profiling (2.21 ms) : 2189, 2230
. : milestone, 2210,
tracing (1.8 ms) : 1783, 1817
. : milestone, 1800,
section candidate
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.211 ms) : 3166, 3257
. : milestone, 3211,
iast_FULL (6.094 ms) : 6031, 6158
. : milestone, 6094,
iast_GLOBAL (3.423 ms) : 3374, 3471
. : milestone, 3423,
profiling (2.095 ms) : 2077, 2114
. : milestone, 2095,
tracing (1.839 ms) : 1821, 1856
. : milestone, 1839,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.758 ms) : 3537, 3979
. : milestone, 3758,
iast (2.254 ms) : 2185, 2322
. : milestone, 2254,
iast_GLOBAL (2.301 ms) : 2232, 2371
. : milestone, 2301,
profiling (2.08 ms) : 2025, 2135
. : milestone, 2080,
tracing (2.057 ms) : 2004, 2110
. : milestone, 2057,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.675 ms) : 3459, 3892
. : milestone, 3675,
iast (2.256 ms) : 2187, 2325
. : milestone, 2256,
iast_GLOBAL (2.29 ms) : 2221, 2359
. : milestone, 2290,
profiling (2.073 ms) : 2019, 2128
. : milestone, 2073,
tracing (2.061 ms) : 2007, 2114
. : milestone, 2061,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~e3d55d51d7, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (15.263 s) : 15263000, 15263000
. : milestone, 15263000,
appsec (15.359 s) : 15359000, 15359000
. : milestone, 15359000,
iast (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
iast_GLOBAL (17.66 s) : 17660000, 17660000
. : milestone, 17660000,
profiling (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
tracing (14.513 s) : 14513000, 14513000
. : milestone, 14513000,
section candidate
no_agent (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
appsec (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
iast (17.907 s) : 17907000, 17907000
. : milestone, 17907000,
iast_GLOBAL (17.85 s) : 17850000, 17850000
. : milestone, 17850000,
profiling (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
tracing (14.591 s) : 14591000, 14591000
. : milestone, 14591000,
|
46d6ef3 to
b5ee6b5
Compare
b5ee6b5 to
e3d55d5
Compare
|
We can instead remove the entire CorrelationAccess class: #10481! |
What Does This Do
Add a test-only
TEST_INSTANCEto theCorrelationAccessclass. Now instead of mutating a final field inCapturedSnapshotTestto introduce aspy, we can set thespyto be a non-finalTEST_INSTANCE.Motivation
Mutating final fields will introduce warnings starting in Java 26 and be disallowed in a later release (JEP 500).
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-594