-
Notifications
You must be signed in to change notification settings - Fork 324
Avoid final field mutation in Weaver instrumentation #10475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059222
Total [baseline] (8.736 s) : 0, 8736369
Agent [candidate] (1.063 s) : 0, 1063116
Total [candidate] (8.718 s) : 0, 8718357
section iast
Agent [baseline] (1.241 s) : 0, 1240856
Total [baseline] (9.403 s) : 0, 9403296
Agent [candidate] (1.224 s) : 0, 1223676
Total [candidate] (9.351 s) : 0, 9351479
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (623.694 ms) : 0, 623694
BytebuddyAgent [candidate] (626.653 ms) : 0, 626653
AgentMeter [baseline] (28.795 ms) : 0, 28795
AgentMeter [candidate] (28.931 ms) : 0, 28931
GlobalTracer [baseline] (257.092 ms) : 0, 257092
GlobalTracer [candidate] (258.522 ms) : 0, 258522
AppSec [baseline] (32.87 ms) : 0, 32870
AppSec [candidate] (32.885 ms) : 0, 32885
Debugger [baseline] (62.653 ms) : 0, 62653
Debugger [candidate] (60.37 ms) : 0, 60370
Remote Config [baseline] (614.663 µs) : 0, 615
Remote Config [candidate] (609.761 µs) : 0, 610
Telemetry [baseline] (9.118 ms) : 0, 9118
Telemetry [candidate] (9.9 ms) : 0, 9900
Flare Poller [baseline] (7.678 ms) : 0, 7678
Flare Poller [candidate] (8.554 ms) : 0, 8554
section iast
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (802.069 ms) : 0, 802069
BytebuddyAgent [candidate] (789.528 ms) : 0, 789528
AgentMeter [baseline] (11.595 ms) : 0, 11595
AgentMeter [candidate] (11.195 ms) : 0, 11195
GlobalTracer [baseline] (249.915 ms) : 0, 249915
GlobalTracer [candidate] (247.828 ms) : 0, 247828
AppSec [baseline] (33.417 ms) : 0, 33417
AppSec [candidate] (35.215 ms) : 0, 35215
Debugger [baseline] (67.044 ms) : 0, 67044
Debugger [candidate] (64.029 ms) : 0, 64029
Remote Config [baseline] (548.93 µs) : 0, 549
Remote Config [candidate] (547.995 µs) : 0, 548
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.531 ms) : 0, 8531
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.493 ms) : 0, 3493
IAST [baseline] (27.22 ms) : 0, 27220
IAST [candidate] (26.695 ms) : 0, 26695
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067372
Total [baseline] (10.982 s) : 0, 10982337
Agent [candidate] (1.056 s) : 0, 1056469
Total [candidate] (11.002 s) : 0, 11002440
section appsec
Agent [baseline] (1.235 s) : 0, 1235044
Total [baseline] (10.993 s) : 0, 10993148
Agent [candidate] (1.234 s) : 0, 1234287
Total [candidate] (11.039 s) : 0, 11039407
section iast
Agent [baseline] (1.229 s) : 0, 1229185
Total [baseline] (11.14 s) : 0, 11140241
Agent [candidate] (1.226 s) : 0, 1225721
Total [candidate] (11.247 s) : 0, 11247229
section profiling
Agent [baseline] (1.193 s) : 0, 1192694
Total [baseline] (10.91 s) : 0, 10909615
Agent [candidate] (1.196 s) : 0, 1195651
Total [candidate] (10.864 s) : 0, 10864144
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (628.666 ms) : 0, 628666
BytebuddyAgent [candidate] (622.434 ms) : 0, 622434
AgentMeter [baseline] (28.967 ms) : 0, 28967
AgentMeter [candidate] (28.7 ms) : 0, 28700
GlobalTracer [baseline] (259.178 ms) : 0, 259178
GlobalTracer [candidate] (257.12 ms) : 0, 257120
AppSec [baseline] (33.274 ms) : 0, 33274
AppSec [candidate] (32.828 ms) : 0, 32828
Debugger [baseline] (64.2 ms) : 0, 64200
Debugger [candidate] (63.186 ms) : 0, 63186
Remote Config [baseline] (621.6 µs) : 0, 622
Remote Config [candidate] (599.856 µs) : 0, 600
Telemetry [baseline] (9.315 ms) : 0, 9315
Telemetry [candidate] (9.032 ms) : 0, 9032
Flare Poller [baseline] (6.174 ms) : 0, 6174
Flare Poller [candidate] (6.085 ms) : 0, 6085
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (655.6 ms) : 0, 655600
BytebuddyAgent [candidate] (653.979 ms) : 0, 653979
AgentMeter [baseline] (11.822 ms) : 0, 11822
AgentMeter [candidate] (11.87 ms) : 0, 11870
GlobalTracer [baseline] (257.417 ms) : 0, 257417
GlobalTracer [candidate] (257.488 ms) : 0, 257488
AppSec [baseline] (167.066 ms) : 0, 167066
AppSec [candidate] (167.494 ms) : 0, 167494
Debugger [baseline] (67.49 ms) : 0, 67490
Debugger [candidate] (67.687 ms) : 0, 67687
Remote Config [baseline] (689.076 µs) : 0, 689
Remote Config [candidate] (666.661 µs) : 0, 667
Telemetry [baseline] (9.316 ms) : 0, 9316
Telemetry [candidate] (9.423 ms) : 0, 9423
Flare Poller [baseline] (3.608 ms) : 0, 3608
Flare Poller [candidate] (3.652 ms) : 0, 3652
IAST [baseline] (25.414 ms) : 0, 25414
IAST [candidate] (25.475 ms) : 0, 25475
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (792.711 ms) : 0, 792711
BytebuddyAgent [candidate] (790.234 ms) : 0, 790234
AgentMeter [baseline] (11.173 ms) : 0, 11173
AgentMeter [candidate] (11.19 ms) : 0, 11190
GlobalTracer [baseline] (248.422 ms) : 0, 248422
GlobalTracer [candidate] (247.829 ms) : 0, 247829
AppSec [baseline] (33.978 ms) : 0, 33978
AppSec [candidate] (34.643 ms) : 0, 34643
Debugger [baseline] (66.907 ms) : 0, 66907
Debugger [candidate] (65.906 ms) : 0, 65906
Remote Config [baseline] (541.036 µs) : 0, 541
Remote Config [candidate] (550.734 µs) : 0, 551
Telemetry [baseline] (8.519 ms) : 0, 8519
Telemetry [candidate] (8.627 ms) : 0, 8627
Flare Poller [baseline] (3.476 ms) : 0, 3476
Flare Poller [candidate] (3.438 ms) : 0, 3438
IAST [baseline] (26.904 ms) : 0, 26904
IAST [candidate] (26.757 ms) : 0, 26757
section profiling
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.241 ms) : 0, 1241
BytebuddyAgent [baseline] (681.644 ms) : 0, 681644
BytebuddyAgent [candidate] (681.577 ms) : 0, 681577
AgentMeter [baseline] (8.693 ms) : 0, 8693
AgentMeter [candidate] (8.742 ms) : 0, 8742
GlobalTracer [baseline] (218.026 ms) : 0, 218026
GlobalTracer [candidate] (218.556 ms) : 0, 218556
AppSec [baseline] (32.59 ms) : 0, 32590
AppSec [candidate] (33.027 ms) : 0, 33027
Debugger [baseline] (68.004 ms) : 0, 68004
Debugger [candidate] (68.409 ms) : 0, 68409
Remote Config [baseline] (595.063 µs) : 0, 595
Remote Config [candidate] (597.381 µs) : 0, 597
Telemetry [baseline] (8.809 ms) : 0, 8809
Telemetry [candidate] (8.803 ms) : 0, 8803
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.789 ms) : 0, 3789
ProfilingAgent [baseline] (99.472 ms) : 0, 99472
ProfilingAgent [candidate] (100.613 ms) : 0, 100613
Profiling [baseline] (100.048 ms) : 0, 100048
Profiling [candidate] (101.185 ms) : 0, 101185
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (17.917 ms) : 17734, 18100
. : milestone, 17917,
appsec (18.386 ms) : 18198, 18573
. : milestone, 18386,
code_origins (17.751 ms) : 17575, 17928
. : milestone, 17751,
iast (17.49 ms) : 17316, 17663
. : milestone, 17490,
profiling (18.784 ms) : 18597, 18970
. : milestone, 18784,
tracing (17.763 ms) : 17585, 17942
. : milestone, 17763,
section candidate
no_agent (17.835 ms) : 17653, 18016
. : milestone, 17835,
appsec (18.42 ms) : 18233, 18606
. : milestone, 18420,
code_origins (17.78 ms) : 17603, 17958
. : milestone, 17780,
iast (17.459 ms) : 17290, 17629
. : milestone, 17459,
profiling (18.697 ms) : 18513, 18881
. : milestone, 18697,
tracing (17.618 ms) : 17443, 17793
. : milestone, 17618,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.17 ms) : 1159, 1182
. : milestone, 1170,
iast (3.245 ms) : 3199, 3292
. : milestone, 3245,
iast_FULL (5.726 ms) : 5670, 5782
. : milestone, 5726,
iast_GLOBAL (3.541 ms) : 3487, 3596
. : milestone, 3541,
profiling (2.191 ms) : 2170, 2211
. : milestone, 2191,
tracing (1.857 ms) : 1840, 1873
. : milestone, 1857,
section candidate
no_agent (1.2 ms) : 1189, 1212
. : milestone, 1200,
iast (3.135 ms) : 3097, 3173
. : milestone, 3135,
iast_FULL (5.902 ms) : 5842, 5963
. : milestone, 5902,
iast_GLOBAL (3.485 ms) : 3426, 3544
. : milestone, 3485,
profiling (2.03 ms) : 2012, 2047
. : milestone, 2030,
tracing (1.816 ms) : 1801, 1832
. : milestone, 1816,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.539 ms) : 2482, 2597
. : milestone, 2539,
iast (2.257 ms) : 2188, 2326
. : milestone, 2257,
iast_GLOBAL (2.297 ms) : 2227, 2366
. : milestone, 2297,
profiling (2.097 ms) : 2041, 2154
. : milestone, 2097,
tracing (2.051 ms) : 1998, 2105
. : milestone, 2051,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.482 ms) : 2428, 2537
. : milestone, 2482,
iast (2.257 ms) : 2188, 2327
. : milestone, 2257,
iast_GLOBAL (2.311 ms) : 2241, 2380
. : milestone, 2311,
profiling (2.102 ms) : 2045, 2159
. : milestone, 2102,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~cbc36ad0ff, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
appsec (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
iast (18.122 s) : 18122000, 18122000
. : milestone, 18122000,
iast_GLOBAL (17.709 s) : 17709000, 17709000
. : milestone, 17709000,
profiling (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
tracing (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
section candidate
no_agent (15.445 s) : 15445000, 15445000
. : milestone, 15445000,
appsec (14.563 s) : 14563000, 14563000
. : milestone, 14563000,
iast (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
iast_GLOBAL (17.768 s) : 17768000, 17768000
. : milestone, 17768000,
profiling (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
tracing (14.546 s) : 14546000, 14546000
. : milestone, 14546000,
|
What Does This Do
WIP
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]