-
Notifications
You must be signed in to change notification settings - Fork 324
Avoid final field mutation in UnsafeUtils #10476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sarahchen6
wants to merge
2
commits into
master
Choose a base branch
from
sarahchen6/refactor-unsafe-utils-final-mutation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Avoid final field mutation in UnsafeUtils #10476
sarahchen6
wants to merge
2
commits into
master
from
sarahchen6/refactor-unsafe-utils-final-mutation
+41
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056799
Total [baseline] (8.727 s) : 0, 8726786
Agent [candidate] (1.054 s) : 0, 1054230
Total [candidate] (8.712 s) : 0, 8712116
section iast
Agent [baseline] (1.227 s) : 0, 1227488
Total [baseline] (9.381 s) : 0, 9380791
Agent [candidate] (1.229 s) : 0, 1229401
Total [candidate] (9.416 s) : 0, 9416224
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (622.497 ms) : 0, 622497
BytebuddyAgent [candidate] (622.632 ms) : 0, 622632
AgentMeter [baseline] (28.621 ms) : 0, 28621
AgentMeter [candidate] (28.732 ms) : 0, 28732
GlobalTracer [baseline] (256.509 ms) : 0, 256509
GlobalTracer [candidate] (257.116 ms) : 0, 257116
AppSec [baseline] (32.655 ms) : 0, 32655
AppSec [candidate] (32.837 ms) : 0, 32837
Debugger [baseline] (61.615 ms) : 0, 61615
Debugger [candidate] (60.537 ms) : 0, 60537
Remote Config [baseline] (604.952 µs) : 0, 605
Remote Config [candidate] (611.295 µs) : 0, 611
Telemetry [baseline] (11.406 ms) : 0, 11406
Telemetry [candidate] (9.909 ms) : 0, 9909
Flare Poller [baseline] (6.114 ms) : 0, 6114
Flare Poller [candidate] (5.242 ms) : 0, 5242
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (790.898 ms) : 0, 790898
BytebuddyAgent [candidate] (792.097 ms) : 0, 792097
AgentMeter [baseline] (11.225 ms) : 0, 11225
AgentMeter [candidate] (11.239 ms) : 0, 11239
GlobalTracer [baseline] (248.605 ms) : 0, 248605
GlobalTracer [candidate] (249.315 ms) : 0, 249315
AppSec [baseline] (34.077 ms) : 0, 34077
AppSec [candidate] (32.478 ms) : 0, 32478
Debugger [baseline] (66.185 ms) : 0, 66185
Debugger [candidate] (67.894 ms) : 0, 67894
Remote Config [baseline] (550.307 µs) : 0, 550
Remote Config [candidate] (546.016 µs) : 0, 546
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (8.607 ms) : 0, 8607
Flare Poller [baseline] (3.615 ms) : 0, 3615
Flare Poller [candidate] (3.466 ms) : 0, 3466
IAST [baseline] (26.78 ms) : 0, 26780
IAST [candidate] (27.055 ms) : 0, 27055
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059190
Total [baseline] (11.054 s) : 0, 11053703
Agent [candidate] (1.064 s) : 0, 1063976
Total [candidate] (10.938 s) : 0, 10938079
section appsec
Agent [baseline] (1.232 s) : 0, 1232137
Total [baseline] (11.028 s) : 0, 11028282
Agent [candidate] (1.233 s) : 0, 1233309
Total [candidate] (11.035 s) : 0, 11034684
section iast
Agent [baseline] (1.233 s) : 0, 1232985
Total [baseline] (11.15 s) : 0, 11149902
Agent [candidate] (1.229 s) : 0, 1229482
Total [candidate] (11.26 s) : 0, 11259808
section profiling
Agent [baseline] (1.194 s) : 0, 1194027
Total [baseline] (10.983 s) : 0, 10983358
Agent [candidate] (1.186 s) : 0, 1186128
Total [candidate] (10.938 s) : 0, 10937763
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (623.608 ms) : 0, 623608
BytebuddyAgent [candidate] (626.67 ms) : 0, 626670
AgentMeter [baseline] (28.793 ms) : 0, 28793
AgentMeter [candidate] (28.902 ms) : 0, 28902
GlobalTracer [baseline] (256.886 ms) : 0, 256886
GlobalTracer [candidate] (258.196 ms) : 0, 258196
AppSec [baseline] (32.999 ms) : 0, 32999
AppSec [candidate] (33.01 ms) : 0, 33010
Debugger [baseline] (64.341 ms) : 0, 64341
Debugger [candidate] (64.478 ms) : 0, 64478
Remote Config [baseline] (617.647 µs) : 0, 618
Remote Config [candidate] (618.074 µs) : 0, 618
Telemetry [baseline] (9.932 ms) : 0, 9932
Telemetry [candidate] (9.139 ms) : 0, 9139
Flare Poller [baseline] (5.334 ms) : 0, 5334
Flare Poller [candidate] (6.111 ms) : 0, 6111
section appsec
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (651.964 ms) : 0, 651964
BytebuddyAgent [candidate] (651.79 ms) : 0, 651790
AgentMeter [baseline] (11.807 ms) : 0, 11807
AgentMeter [candidate] (11.898 ms) : 0, 11898
GlobalTracer [baseline] (257.521 ms) : 0, 257521
GlobalTracer [candidate] (258.014 ms) : 0, 258014
AppSec [baseline] (167.482 ms) : 0, 167482
AppSec [candidate] (167.786 ms) : 0, 167786
Debugger [baseline] (67.818 ms) : 0, 67818
Debugger [candidate] (68.054 ms) : 0, 68054
Remote Config [baseline] (662.414 µs) : 0, 662
Remote Config [candidate] (665.125 µs) : 0, 665
Telemetry [baseline] (9.278 ms) : 0, 9278
Telemetry [candidate] (9.335 ms) : 0, 9335
Flare Poller [baseline] (3.643 ms) : 0, 3643
Flare Poller [candidate] (3.709 ms) : 0, 3709
IAST [baseline] (25.448 ms) : 0, 25448
IAST [candidate] (25.517 ms) : 0, 25517
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (794.599 ms) : 0, 794599
BytebuddyAgent [candidate] (791.741 ms) : 0, 791741
AgentMeter [baseline] (11.269 ms) : 0, 11269
AgentMeter [candidate] (11.192 ms) : 0, 11192
GlobalTracer [baseline] (249.781 ms) : 0, 249781
GlobalTracer [candidate] (248.789 ms) : 0, 248789
AppSec [baseline] (33.079 ms) : 0, 33079
AppSec [candidate] (33.972 ms) : 0, 33972
Debugger [baseline] (67.813 ms) : 0, 67813
Debugger [candidate] (67.349 ms) : 0, 67349
Remote Config [baseline] (548.908 µs) : 0, 549
Remote Config [candidate] (571.222 µs) : 0, 571
Telemetry [baseline] (8.704 ms) : 0, 8704
Telemetry [candidate] (8.769 ms) : 0, 8769
Flare Poller [baseline] (3.476 ms) : 0, 3476
Flare Poller [candidate] (3.599 ms) : 0, 3599
IAST [baseline] (27.024 ms) : 0, 27024
IAST [candidate] (26.845 ms) : 0, 26845
section profiling
ProfilingAgent [baseline] (99.653 ms) : 0, 99653
ProfilingAgent [candidate] (99.523 ms) : 0, 99523
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (682.046 ms) : 0, 682046
BytebuddyAgent [candidate] (677.71 ms) : 0, 677710
AgentMeter [baseline] (8.769 ms) : 0, 8769
AgentMeter [candidate] (8.646 ms) : 0, 8646
GlobalTracer [baseline] (217.974 ms) : 0, 217974
GlobalTracer [candidate] (216.621 ms) : 0, 216621
AppSec [baseline] (32.681 ms) : 0, 32681
AppSec [candidate] (31.961 ms) : 0, 31961
Debugger [baseline] (68.34 ms) : 0, 68340
Debugger [candidate] (67.584 ms) : 0, 67584
Remote Config [baseline] (590.464 µs) : 0, 590
Remote Config [candidate] (594.227 µs) : 0, 594
Telemetry [baseline] (8.704 ms) : 0, 8704
Telemetry [candidate] (8.632 ms) : 0, 8632
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.755 ms) : 0, 3755
Profiling [baseline] (100.225 ms) : 0, 100225
Profiling [candidate] (100.088 ms) : 0, 100088
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1169, 1193
. : milestone, 1181,
iast (3.228 ms) : 3183, 3273
. : milestone, 3228,
iast_FULL (5.853 ms) : 5794, 5912
. : milestone, 5853,
iast_GLOBAL (3.514 ms) : 3463, 3565
. : milestone, 3514,
profiling (2.257 ms) : 2237, 2278
. : milestone, 2257,
tracing (1.786 ms) : 1771, 1800
. : milestone, 1786,
section candidate
no_agent (1.174 ms) : 1163, 1186
. : milestone, 1174,
iast (3.187 ms) : 3142, 3233
. : milestone, 3187,
iast_FULL (5.937 ms) : 5876, 5997
. : milestone, 5937,
iast_GLOBAL (3.462 ms) : 3416, 3509
. : milestone, 3462,
profiling (2.058 ms) : 2040, 2075
. : milestone, 2058,
tracing (1.802 ms) : 1787, 1817
. : milestone, 1802,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (18.196 ms) : 18008, 18383
. : milestone, 18196,
appsec (18.81 ms) : 18621, 19000
. : milestone, 18810,
code_origins (17.904 ms) : 17724, 18083
. : milestone, 17904,
iast (17.655 ms) : 17479, 17830
. : milestone, 17655,
profiling (18.853 ms) : 18660, 19045
. : milestone, 18853,
tracing (17.892 ms) : 17715, 18069
. : milestone, 17892,
section candidate
no_agent (18.162 ms) : 17976, 18348
. : milestone, 18162,
appsec (18.823 ms) : 18634, 19013
. : milestone, 18823,
code_origins (18.737 ms) : 18548, 18925
. : milestone, 18737,
iast (17.573 ms) : 17397, 17750
. : milestone, 17573,
profiling (18.475 ms) : 18288, 18662
. : milestone, 18475,
tracing (17.693 ms) : 17518, 17868
. : milestone, 17693,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (15.375 s) : 15375000, 15375000
. : milestone, 15375000,
appsec (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
iast (18.009 s) : 18009000, 18009000
. : milestone, 18009000,
iast_GLOBAL (17.603 s) : 17603000, 17603000
. : milestone, 17603000,
profiling (14.827 s) : 14827000, 14827000
. : milestone, 14827000,
tracing (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
section candidate
no_agent (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
appsec (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
iast (17.878 s) : 17878000, 17878000
. : milestone, 17878000,
iast_GLOBAL (17.696 s) : 17696000, 17696000
. : milestone, 17696000,
profiling (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
tracing (14.715 s) : 14715000, 14715000
. : milestone, 14715000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~f66b1b55eb, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.725 ms) : 3506, 3944
. : milestone, 3725,
iast (2.247 ms) : 2178, 2316
. : milestone, 2247,
iast_GLOBAL (2.286 ms) : 2216, 2355
. : milestone, 2286,
profiling (2.098 ms) : 2041, 2155
. : milestone, 2098,
tracing (2.048 ms) : 1994, 2101
. : milestone, 2048,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.503 ms) : 2447, 2558
. : milestone, 2503,
iast (2.246 ms) : 2177, 2315
. : milestone, 2246,
iast_GLOBAL (2.284 ms) : 2215, 2354
. : milestone, 2284,
profiling (2.067 ms) : 2012, 2121
. : milestone, 2067,
tracing (2.052 ms) : 1998, 2105
. : milestone, 2052,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
When attempting to clone a final field using
UnsafeUtils::cloneFields, skip and instead emit a debug warning that final fields cannot be mutated. Update tests to reflect this as well.Motivation
Prepare for JEP 500 which disallows final field mutations.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-594