-
Notifications
You must be signed in to change notification settings - Fork 324
Move rxjava2 advices to context tracking #10482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amarziali
wants to merge
2
commits into
master
Choose a base branch
from
andrea.marziali/rx-context
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057871
Total [baseline] (10.99 s) : 0, 10990011
Agent [candidate] (1.062 s) : 0, 1062365
Total [candidate] (11.082 s) : 0, 11082195
section appsec
Agent [baseline] (1.24 s) : 0, 1239839
Total [baseline] (11.017 s) : 0, 11016904
Agent [candidate] (1.241 s) : 0, 1240825
Total [candidate] (11.124 s) : 0, 11124486
section iast
Agent [baseline] (1.226 s) : 0, 1226352
Total [baseline] (11.179 s) : 0, 11178648
Agent [candidate] (1.228 s) : 0, 1227761
Total [candidate] (11.155 s) : 0, 11155031
section profiling
Agent [baseline] (1.191 s) : 0, 1190792
Total [baseline] (11.026 s) : 0, 11026494
Agent [candidate] (1.194 s) : 0, 1193841
Total [candidate] (11.044 s) : 0, 11044157
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.169 ms) : 0, 1169
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (622.565 ms) : 0, 622565
BytebuddyAgent [candidate] (627.424 ms) : 0, 627424
AgentMeter [baseline] (28.715 ms) : 0, 28715
AgentMeter [candidate] (28.761 ms) : 0, 28761
GlobalTracer [baseline] (257.151 ms) : 0, 257151
GlobalTracer [candidate] (258.063 ms) : 0, 258063
AppSec [baseline] (32.787 ms) : 0, 32787
AppSec [candidate] (33.072 ms) : 0, 33072
Debugger [baseline] (62.687 ms) : 0, 62687
Debugger [candidate] (60.653 ms) : 0, 60653
Remote Config [baseline] (620.239 µs) : 0, 620
Remote Config [candidate] (627.861 µs) : 0, 628
Telemetry [baseline] (9.733 ms) : 0, 9733
Telemetry [candidate] (9.304 ms) : 0, 9304
Flare Poller [baseline] (7.016 ms) : 0, 7016
Flare Poller [candidate] (7.716 ms) : 0, 7716
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (656.981 ms) : 0, 656981
BytebuddyAgent [candidate] (655.495 ms) : 0, 655495
AgentMeter [baseline] (11.93 ms) : 0, 11930
AgentMeter [candidate] (11.947 ms) : 0, 11947
GlobalTracer [baseline] (259.258 ms) : 0, 259258
GlobalTracer [candidate] (260.157 ms) : 0, 260157
AppSec [baseline] (167.983 ms) : 0, 167983
AppSec [candidate] (168.576 ms) : 0, 168576
Debugger [baseline] (67.824 ms) : 0, 67824
Debugger [candidate] (68.608 ms) : 0, 68608
Remote Config [baseline] (688.956 µs) : 0, 689
Remote Config [candidate] (689.52 µs) : 0, 690
Telemetry [baseline] (9.268 ms) : 0, 9268
Telemetry [candidate] (9.415 ms) : 0, 9415
Flare Poller [baseline] (3.582 ms) : 0, 3582
Flare Poller [candidate] (3.683 ms) : 0, 3683
IAST [baseline] (25.669 ms) : 0, 25669
IAST [candidate] (25.862 ms) : 0, 25862
section iast
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (790.607 ms) : 0, 790607
BytebuddyAgent [candidate] (790.961 ms) : 0, 790961
AgentMeter [baseline] (11.182 ms) : 0, 11182
AgentMeter [candidate] (11.172 ms) : 0, 11172
GlobalTracer [baseline] (248.625 ms) : 0, 248625
GlobalTracer [candidate] (248.79 ms) : 0, 248790
AppSec [baseline] (34.58 ms) : 0, 34580
AppSec [candidate] (34.54 ms) : 0, 34540
Debugger [baseline] (65.495 ms) : 0, 65495
Debugger [candidate] (66.017 ms) : 0, 66017
Remote Config [baseline] (541.736 µs) : 0, 542
Remote Config [candidate] (538.05 µs) : 0, 538
Telemetry [baseline] (8.578 ms) : 0, 8578
Telemetry [candidate] (8.571 ms) : 0, 8571
Flare Poller [baseline] (3.516 ms) : 0, 3516
Flare Poller [candidate] (3.514 ms) : 0, 3514
IAST [baseline] (26.8 ms) : 0, 26800
IAST [candidate] (27.047 ms) : 0, 27047
section profiling
ProfilingAgent [baseline] (99.979 ms) : 0, 99979
ProfilingAgent [candidate] (99.495 ms) : 0, 99495
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.244 ms) : 0, 1244
BytebuddyAgent [baseline] (680.065 ms) : 0, 680065
BytebuddyAgent [candidate] (682.531 ms) : 0, 682531
AgentMeter [baseline] (8.735 ms) : 0, 8735
AgentMeter [candidate] (8.697 ms) : 0, 8697
GlobalTracer [baseline] (217.418 ms) : 0, 217418
GlobalTracer [candidate] (217.65 ms) : 0, 217650
AppSec [baseline] (32.482 ms) : 0, 32482
AppSec [candidate] (32.454 ms) : 0, 32454
Debugger [baseline] (67.932 ms) : 0, 67932
Debugger [candidate] (68.396 ms) : 0, 68396
Remote Config [baseline] (586.247 µs) : 0, 586
Remote Config [candidate] (587.67 µs) : 0, 588
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.837 ms) : 0, 8837
Flare Poller [baseline] (3.814 ms) : 0, 3814
Flare Poller [candidate] (3.813 ms) : 0, 3813
Profiling [baseline] (100.559 ms) : 0, 100559
Profiling [candidate] (100.064 ms) : 0, 100064
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062607
Total [baseline] (8.736 s) : 0, 8736418
Agent [candidate] (1.071 s) : 0, 1070651
Total [candidate] (8.725 s) : 0, 8724751
section iast
Agent [baseline] (1.234 s) : 0, 1234186
Total [baseline] (9.414 s) : 0, 9414405
Agent [candidate] (1.223 s) : 0, 1223172
Total [candidate] (9.371 s) : 0, 9370823
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (626.492 ms) : 0, 626492
BytebuddyAgent [candidate] (632.276 ms) : 0, 632276
AgentMeter [baseline] (28.905 ms) : 0, 28905
AgentMeter [candidate] (28.92 ms) : 0, 28920
GlobalTracer [baseline] (257.979 ms) : 0, 257979
GlobalTracer [candidate] (259.88 ms) : 0, 259880
AppSec [baseline] (33.075 ms) : 0, 33075
AppSec [candidate] (33.347 ms) : 0, 33347
Debugger [baseline] (60.511 ms) : 0, 60511
Debugger [candidate] (63.313 ms) : 0, 63313
Remote Config [baseline] (614.886 µs) : 0, 615
Remote Config [candidate] (620.518 µs) : 0, 621
Telemetry [baseline] (10.695 ms) : 0, 10695
Telemetry [candidate] (9.241 ms) : 0, 9241
Flare Poller [baseline] (7.644 ms) : 0, 7644
Flare Poller [candidate] (6.134 ms) : 0, 6134
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (796.288 ms) : 0, 796288
BytebuddyAgent [candidate] (788.897 ms) : 0, 788897
AgentMeter [baseline] (11.393 ms) : 0, 11393
AgentMeter [candidate] (11.18 ms) : 0, 11180
GlobalTracer [baseline] (249.268 ms) : 0, 249268
GlobalTracer [candidate] (248.101 ms) : 0, 248101
IAST [baseline] (27.234 ms) : 0, 27234
IAST [candidate] (26.879 ms) : 0, 26879
AppSec [baseline] (33.147 ms) : 0, 33147
AppSec [candidate] (33.662 ms) : 0, 33662
Debugger [baseline] (67.347 ms) : 0, 67347
Debugger [candidate] (65.348 ms) : 0, 65348
Remote Config [baseline] (550.156 µs) : 0, 550
Remote Config [candidate] (535.922 µs) : 0, 536
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.569 ms) : 0, 8569
Flare Poller [baseline] (3.578 ms) : 0, 3578
Flare Poller [candidate] (3.468 ms) : 0, 3468
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (18.756 ms) : 18561, 18950
. : milestone, 18756,
appsec (19.516 ms) : 19315, 19716
. : milestone, 19516,
code_origins (17.754 ms) : 17576, 17932
. : milestone, 17754,
iast (17.728 ms) : 17553, 17902
. : milestone, 17728,
profiling (18.892 ms) : 18703, 19080
. : milestone, 18892,
tracing (17.687 ms) : 17512, 17862
. : milestone, 17687,
section candidate
no_agent (18.309 ms) : 18125, 18494
. : milestone, 18309,
appsec (19.224 ms) : 19030, 19419
. : milestone, 19224,
code_origins (18.63 ms) : 18441, 18818
. : milestone, 18630,
iast (17.811 ms) : 17634, 17988
. : milestone, 17811,
profiling (18.746 ms) : 18559, 18934
. : milestone, 18746,
tracing (18.9 ms) : 18712, 19088
. : milestone, 18900,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.228 ms) : 3186, 3270
. : milestone, 3228,
iast_FULL (5.577 ms) : 5523, 5632
. : milestone, 5577,
iast_GLOBAL (3.62 ms) : 3559, 3681
. : milestone, 3620,
profiling (2.187 ms) : 2166, 2208
. : milestone, 2187,
tracing (1.81 ms) : 1795, 1824
. : milestone, 1810,
section candidate
no_agent (1.164 ms) : 1153, 1176
. : milestone, 1164,
iast (3.124 ms) : 3082, 3167
. : milestone, 3124,
iast_FULL (5.775 ms) : 5717, 5833
. : milestone, 5775,
iast_GLOBAL (3.485 ms) : 3425, 3545
. : milestone, 3485,
profiling (2.144 ms) : 2125, 2164
. : milestone, 2144,
tracing (1.774 ms) : 1760, 1789
. : milestone, 1774,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.77 ms) : 3549, 3990
. : milestone, 3770,
iast (2.269 ms) : 2200, 2338
. : milestone, 2269,
iast_GLOBAL (2.313 ms) : 2244, 2383
. : milestone, 2313,
profiling (2.104 ms) : 2049, 2160
. : milestone, 2104,
tracing (2.074 ms) : 2021, 2128
. : milestone, 2074,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.774 ms) : 3553, 3995
. : milestone, 3774,
iast (2.27 ms) : 2201, 2340
. : milestone, 2270,
iast_GLOBAL (2.309 ms) : 2239, 2378
. : milestone, 2309,
profiling (2.113 ms) : 2056, 2169
. : milestone, 2113,
tracing (2.091 ms) : 2037, 2145
. : milestone, 2091,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~fd432d27f0, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
appsec (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
iast (18.453 s) : 18453000, 18453000
. : milestone, 18453000,
iast_GLOBAL (17.731 s) : 17731000, 17731000
. : milestone, 17731000,
profiling (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
tracing (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
section candidate
no_agent (15.407 s) : 15407000, 15407000
. : milestone, 15407000,
appsec (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
iast (18.144 s) : 18144000, 18144000
. : milestone, 18144000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
tracing (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR moves the rxjava2 module advices to context tracking and replaces usage of span and scope with context and contextScope.
Also, a RxJavaModule is created to group all the instrumenters.
Finally, the
RxJavaPluginsInstrumentationhas been deleted since it did not contains any actionable adviceMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]