-
Notifications
You must be signed in to change notification settings - Fork 324
Move reactor-core and rective-streams advices to context tracking #10483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amarziali
wants to merge
3
commits into
master
Choose a base branch
from
andrea.marziali/reactive
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064186
Total [baseline] (8.739 s) : 0, 8738932
Agent [candidate] (1.061 s) : 0, 1060839
Total [candidate] (8.717 s) : 0, 8717004
section iast
Agent [baseline] (1.226 s) : 0, 1226269
Total [baseline] (9.385 s) : 0, 9385194
Agent [candidate] (1.237 s) : 0, 1236795
Total [candidate] (9.403 s) : 0, 9402834
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (628.115 ms) : 0, 628115
BytebuddyAgent [candidate] (624.405 ms) : 0, 624405
AgentMeter [baseline] (29.051 ms) : 0, 29051
AgentMeter [candidate] (28.692 ms) : 0, 28692
GlobalTracer [baseline] (259.06 ms) : 0, 259060
GlobalTracer [candidate] (257.608 ms) : 0, 257608
AppSec [baseline] (32.941 ms) : 0, 32941
AppSec [candidate] (32.962 ms) : 0, 32962
Debugger [baseline] (62.15 ms) : 0, 62150
Debugger [candidate] (62.397 ms) : 0, 62397
Remote Config [baseline] (621.435 µs) : 0, 621
Remote Config [candidate] (599.13 µs) : 0, 599
Telemetry [baseline] (9.244 ms) : 0, 9244
Telemetry [candidate] (10.612 ms) : 0, 10612
Flare Poller [baseline] (6.129 ms) : 0, 6129
Flare Poller [candidate] (6.907 ms) : 0, 6907
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (790.806 ms) : 0, 790806
BytebuddyAgent [candidate] (797.501 ms) : 0, 797501
AgentMeter [baseline] (11.143 ms) : 0, 11143
AgentMeter [candidate] (11.439 ms) : 0, 11439
GlobalTracer [baseline] (248.113 ms) : 0, 248113
GlobalTracer [candidate] (250.035 ms) : 0, 250035
AppSec [baseline] (32.383 ms) : 0, 32383
AppSec [candidate] (34.297 ms) : 0, 34297
Debugger [baseline] (67.985 ms) : 0, 67985
Debugger [candidate] (66.733 ms) : 0, 66733
Remote Config [baseline] (538.515 µs) : 0, 539
Remote Config [candidate] (565.01 µs) : 0, 565
Telemetry [baseline] (8.471 ms) : 0, 8471
Telemetry [candidate] (8.638 ms) : 0, 8638
Flare Poller [baseline] (3.497 ms) : 0, 3497
Flare Poller [candidate] (3.516 ms) : 0, 3516
IAST [baseline] (26.726 ms) : 0, 26726
IAST [candidate] (27.157 ms) : 0, 27157
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059450
Total [baseline] (10.999 s) : 0, 10998640
Agent [candidate] (1.058 s) : 0, 1057844
Total [candidate] (10.962 s) : 0, 10961859
section appsec
Agent [baseline] (1.242 s) : 0, 1241687
Total [baseline] (11.12 s) : 0, 11119542
Agent [candidate] (1.24 s) : 0, 1239622
Total [candidate] (11.187 s) : 0, 11186568
section iast
Agent [baseline] (1.229 s) : 0, 1229040
Total [baseline] (11.164 s) : 0, 11163565
Agent [candidate] (1.23 s) : 0, 1229717
Total [candidate] (11.195 s) : 0, 11195430
section profiling
Agent [baseline] (1.191 s) : 0, 1190882
Total [baseline] (10.921 s) : 0, 10921424
Agent [candidate] (1.198 s) : 0, 1197722
Total [candidate] (10.982 s) : 0, 10982238
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (625.301 ms) : 0, 625301
BytebuddyAgent [candidate] (622.459 ms) : 0, 622459
AgentMeter [baseline] (28.649 ms) : 0, 28649
AgentMeter [candidate] (28.594 ms) : 0, 28594
GlobalTracer [baseline] (257.918 ms) : 0, 257918
GlobalTracer [candidate] (257.302 ms) : 0, 257302
AppSec [baseline] (33.033 ms) : 0, 33033
AppSec [candidate] (32.891 ms) : 0, 32891
Debugger [baseline] (62.738 ms) : 0, 62738
Debugger [candidate] (63.391 ms) : 0, 63391
Remote Config [baseline] (614.793 µs) : 0, 615
Remote Config [candidate] (608.119 µs) : 0, 608
Telemetry [baseline] (9.178 ms) : 0, 9178
Telemetry [candidate] (10.661 ms) : 0, 10661
Flare Poller [baseline] (5.311 ms) : 0, 5311
Flare Poller [candidate] (5.415 ms) : 0, 5415
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (657.84 ms) : 0, 657840
BytebuddyAgent [candidate] (656.087 ms) : 0, 656087
AgentMeter [baseline] (11.928 ms) : 0, 11928
AgentMeter [candidate] (11.897 ms) : 0, 11897
GlobalTracer [baseline] (259.659 ms) : 0, 259659
GlobalTracer [candidate] (259.552 ms) : 0, 259552
IAST [baseline] (25.632 ms) : 0, 25632
IAST [candidate] (25.718 ms) : 0, 25718
AppSec [baseline] (168.149 ms) : 0, 168149
AppSec [candidate] (168.268 ms) : 0, 168268
Debugger [baseline] (67.983 ms) : 0, 67983
Debugger [candidate] (67.825 ms) : 0, 67825
Remote Config [baseline] (680.805 µs) : 0, 681
Remote Config [candidate] (668.805 µs) : 0, 669
Telemetry [baseline] (9.452 ms) : 0, 9452
Telemetry [candidate] (9.433 ms) : 0, 9433
Flare Poller [baseline] (3.658 ms) : 0, 3658
Flare Poller [candidate] (3.683 ms) : 0, 3683
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (791.767 ms) : 0, 791767
BytebuddyAgent [candidate] (792.153 ms) : 0, 792153
AgentMeter [baseline] (11.217 ms) : 0, 11217
AgentMeter [candidate] (11.238 ms) : 0, 11238
GlobalTracer [baseline] (248.666 ms) : 0, 248666
GlobalTracer [candidate] (249.321 ms) : 0, 249321
IAST [baseline] (26.974 ms) : 0, 26974
IAST [candidate] (26.88 ms) : 0, 26880
AppSec [baseline] (33.042 ms) : 0, 33042
AppSec [candidate] (34.683 ms) : 0, 34683
Debugger [baseline] (67.918 ms) : 0, 67918
Debugger [candidate] (65.954 ms) : 0, 65954
Remote Config [baseline] (539.757 µs) : 0, 540
Remote Config [candidate] (564.513 µs) : 0, 565
Telemetry [baseline] (8.714 ms) : 0, 8714
Telemetry [candidate] (8.682 ms) : 0, 8682
Flare Poller [baseline] (3.547 ms) : 0, 3547
Flare Poller [candidate] (3.515 ms) : 0, 3515
section profiling
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.253 ms) : 0, 1253
BytebuddyAgent [baseline] (681.971 ms) : 0, 681971
BytebuddyAgent [candidate] (683.658 ms) : 0, 683658
AgentMeter [baseline] (8.627 ms) : 0, 8627
AgentMeter [candidate] (8.762 ms) : 0, 8762
GlobalTracer [baseline] (216.94 ms) : 0, 216940
GlobalTracer [candidate] (219.495 ms) : 0, 219495
AppSec [baseline] (32.131 ms) : 0, 32131
AppSec [candidate] (32.944 ms) : 0, 32944
Debugger [baseline] (67.572 ms) : 0, 67572
Debugger [candidate] (68.568 ms) : 0, 68568
Remote Config [baseline] (593.568 µs) : 0, 594
Remote Config [candidate] (596.099 µs) : 0, 596
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.794 ms) : 0, 8794
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (3.785 ms) : 0, 3785
ProfilingAgent [baseline] (99.03 ms) : 0, 99030
ProfilingAgent [candidate] (99.448 ms) : 0, 99448
Profiling [baseline] (99.597 ms) : 0, 99597
Profiling [candidate] (100.025 ms) : 0, 100025
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.167 ms) : 1156, 1179
. : milestone, 1167,
iast (3.236 ms) : 3190, 3281
. : milestone, 3236,
iast_FULL (5.856 ms) : 5798, 5914
. : milestone, 5856,
iast_GLOBAL (3.543 ms) : 3485, 3602
. : milestone, 3543,
profiling (1.969 ms) : 1952, 1987
. : milestone, 1969,
tracing (1.774 ms) : 1759, 1788
. : milestone, 1774,
section candidate
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.152 ms) : 3109, 3194
. : milestone, 3152,
iast_FULL (5.852 ms) : 5794, 5910
. : milestone, 5852,
iast_GLOBAL (3.638 ms) : 3582, 3694
. : milestone, 3638,
profiling (2.024 ms) : 2005, 2042
. : milestone, 2024,
tracing (1.804 ms) : 1788, 1820
. : milestone, 1804,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (18.205 ms) : 18016, 18394
. : milestone, 18205,
appsec (18.523 ms) : 18335, 18710
. : milestone, 18523,
code_origins (17.396 ms) : 17223, 17569
. : milestone, 17396,
iast (18.266 ms) : 18081, 18450
. : milestone, 18266,
profiling (18.506 ms) : 18315, 18696
. : milestone, 18506,
tracing (17.545 ms) : 17373, 17717
. : milestone, 17545,
section candidate
no_agent (19.319 ms) : 19123, 19516
. : milestone, 19319,
appsec (18.606 ms) : 18415, 18798
. : milestone, 18606,
code_origins (18.539 ms) : 18352, 18725
. : milestone, 18539,
iast (18.788 ms) : 18595, 18981
. : milestone, 18788,
profiling (18.644 ms) : 18456, 18833
. : milestone, 18644,
tracing (17.894 ms) : 17716, 18072
. : milestone, 17894,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.495 ms) : 2440, 2551
. : milestone, 2495,
iast (2.268 ms) : 2198, 2338
. : milestone, 2268,
iast_GLOBAL (2.308 ms) : 2237, 2378
. : milestone, 2308,
profiling (2.097 ms) : 2041, 2153
. : milestone, 2097,
tracing (2.078 ms) : 2023, 2133
. : milestone, 2078,
section candidate
no_agent (1.47 ms) : 1459, 1481
. : milestone, 1470,
appsec (3.75 ms) : 3528, 3972
. : milestone, 3750,
iast (2.254 ms) : 2184, 2325
. : milestone, 2254,
iast_GLOBAL (2.299 ms) : 2229, 2369
. : milestone, 2299,
profiling (2.093 ms) : 2037, 2149
. : milestone, 2093,
tracing (2.062 ms) : 2008, 2117
. : milestone, 2062,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8bc92c97fe, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (14.749 s) : 14749000, 14749000
. : milestone, 14749000,
appsec (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
iast (17.622 s) : 17622000, 17622000
. : milestone, 17622000,
iast_GLOBAL (17.613 s) : 17613000, 17613000
. : milestone, 17613000,
profiling (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
tracing (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
section candidate
no_agent (15.52 s) : 15520000, 15520000
. : milestone, 15520000,
appsec (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
iast (18.216 s) : 18216000, 18216000
. : milestone, 18216000,
iast_GLOBAL (17.87 s) : 17870000, 17870000
. : milestone, 17870000,
profiling (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
tracing (14.557 s) : 14557000, 14557000
. : milestone, 14557000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Also changes the API and the context stores to use generically Context and not span/scopes
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]