Skip to content

chore(vite.config): exclude '__tests__' directory from coverage reports #10084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sukvvon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(vite.config): exclude '__tests__' directory from coverage reports #10084

sukvvon wants to merge 1 commit into from

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 31, 2026 •
edited by coderabbitai bot
Loading

🎯 Changes

Add exclude: ['src/__tests__/**'] to coverage config in all 16 packages' vite.config.ts.

Istanbul coverage provider does not auto-exclude *.test-d.* files (typecheck-only), causing them to appear with 0% coverage. Excluding the entire __tests__ directory resolves this and ensures only source code is measured.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated test coverage configuration across all packages to exclude test files from coverage metrics. This change improves the accuracy of coverage reports by preventing test files from being counted during coverage collection while maintaining all other existing coverage settings.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2026

⚠️ No Changeset found

Latest commit: bf77a04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR updates Vitest coverage configuration across 16 packages to exclude test files (src/__tests__/**) from coverage reporting, while preserving existing coverage settings (enabled, provider, include patterns).

Changes

Cohort / File(s) Summary
Coverage Configuration Expansion
packages/angular-query-experimental/vite.config.ts, packages/angular-query-persist-client/vite.config.ts, packages/eslint-plugin-query/vite.config.ts, packages/query-async-storage-persister/vite.config.ts, packages/query-broadcast-client-experimental/vite.config.ts, packages/query-core/vite.config.ts, packages/query-devtools/vite.config.ts, packages/query-persist-client-core/vite.config.ts, packages/query-sync-storage-persister/vite.config.ts, packages/react-query-devtools/vite.config.ts, packages/react-query-persist-client/vite.config.ts, packages/react-query/vite.config.ts, packages/solid-query-devtools/vite.config.ts, packages/solid-query-persist-client/vite.config.ts, packages/solid-query/vite.config.ts, packages/vue-query/vite.config.ts		 Added exclude: ['src/__tests__/**'] to coverage configuration to omit test files from coverage reporting across all packages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Upgrade to Vitest v4 #9862: Modifies Vitest-related configuration in vite.config.ts files (coverage and test configuration changes).

Suggested reviewers

  • TkDodo

Poem

🐰 Hop, hop, hopping through configs so fine,
Tests excluded, coverage lines align,
Sixteen packages, one pattern true,
Coverage clean—no test files in view! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and concisely summarizes the main change: adding an exclude pattern to coverage configuration in vite.config files across all packages.
Description check ✅ Passed The pull request description follows the required template with all sections completed: it explains the changes and motivation, has all checklist items addressed, and documents the release impact accurately.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Jan 31, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bf77a04

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 52s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-31 06:07:02 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 31, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10084

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10084

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10084

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10084

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10084

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10084

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10084

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10084

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10084

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10084

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10084

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10084

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10084

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10084

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10084

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10084

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10084

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10084

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10084

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10084

commit: bf77a04

@sukvvon sukvvon marked this pull request as ready for review January 31, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: angular-query-experimental package: angular-query-persist-client package: eslint-plugin-query package: query-async-storage-persister package: query-broadcast-client-experimental package: query-core package: query-devtools package: query-persist-client-core package: query-sync-storage-persister package: react-query package: react-query-devtools package: react-query-persist-client package: solid-query package: solid-query-devtools package: solid-query-persist-client package: vue-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon