fix: Use max() instead of min() for request_max_duration statistic
#1701
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statistics tracking for maximum request duration was incorrectly using min() instead of max(), causing the statistic to always show the minimum duration instead of the maximum. Co-Authored-By: Claude Opus 4.5 <[email protected]>
vdusek
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
+ Coverage 92.45% 92.46% +0.01%
==========================================
Files 157 157
Lines 10482 10489 +7
==========================================
+ Hits 9691 9699 +8
+ Misses 791 790 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Jan 30, 2026
Collaborator
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Could you please add a tiny test for this fix?
Verify that request_max_duration correctly tracks the maximum duration across multiple requests, ensuring it increases for longer requests but doesn't decrease when shorter requests are recorded. Co-Authored-By: Claude Opus 4.5 <[email protected]>
github-actions
bot
added
the
tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statistics tracking for maximum request duration was incorrectly using
min()instead ofmax(), causing the statistic to always show the minimum duration instead of the maximum.Co-Authored-By: Claude Opus 4.5 [email protected]