Skip to content

Conversation

@shrima-cf
Copy link
Contributor

…t_gate_wait_attempt parent span

This will help group the lock and wait span from a single request together

I noticed from this span - https://tracing.cfdata.org/trace/000f2d35a668d2bb that the lock_wait and lock_holds are grouped individually, making it hard to tie the hold and wait to a single request. This change will help fix the issue.

@shrima-cf shrima-cf requested review from a team as code owners January 23, 2026 00:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.15%. Comparing base (d6fce98) to head (d9f80b3).

Files with missing lines Patch % Lines
src/workerd/io/io-gate.c++ 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5948   +/-   ##
=======================================
  Coverage   70.14%   70.15%           
=======================================
  Files         407      407           
  Lines      107306   107307    +1     
  Branches    17985    17985           
=======================================
+ Hits        75273    75281    +8     
+ Misses      21242    21232   -10     
- Partials    10791    10794    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shrima-cf shrima-cf force-pushed the shrima/input-gate-span branch from 085419c to 5314fbb Compare January 26, 2026 23:46
…t_gate_wait_attempt parent span

This will help group the lock and wait span from a single request together
@shrima-cf shrima-cf force-pushed the shrima/input-gate-span branch from 5314fbb to d9f80b3 Compare January 29, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants