-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(a380x/fms): Secondary flight plans for the A380X #10429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnDirectTo.tsx # fbw-common/src/systems/shared/src/persistence.ts
(cherry picked from commit 0439b4a)
…; move CPNY FPLN button code to util
|
@alexr4339 thanks for the test. Hard to judge whether the issues come from this PR, or the underlying base FMS SEC implementation, or were already present before those changes. Are you able to reproduce the same issue on the A380X and A32NX? |
# Conflicts: # .github/CHANGELOG.md # fbw-a32nx/src/systems/fmgc/src/flightplanning/FlightPlanInterface.integration.spec.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/FlightPlanManager.spec.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/MsfsFlightPlanSync.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/legs/ReadonlyFlightPlanLeg.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/plans/BaseFlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/plans/FlightPlan.spec.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/plans/FlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/rpc/FlightPlanRpcClient.spec.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/test/FlightPlan.ts # fbw-a32nx/src/systems/fmgc/src/flightplanning/test/TestFlightPlanService.ts # fbw-a380x/src/systems/instruments/src/MFD/FMC/FlightManagementComputer.ts # fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnAirways.tsx
fbw-a32nx/src/systems/fmgc/src/flightplanning/plans/BaseFlightPlan.ts
Outdated
Show resolved
Hide resolved
fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/SEC/MfdFmsSecIndex.tsx
Outdated
Show resolved
Hide resolved
fbw-a380x/src/systems/instruments/src/MFD/shared/cpnyFplnButtonUtils.tsx
Outdated
Show resolved
Hide resolved
fbw-a380x/src/systems/instruments/src/MsfsAvionicsCommon/UiWidgets/DropdownMenu.tsx
Show resolved
Hide resolved
|
Sorry for the late review, only just got to it 😅 |
# Conflicts: # fbw-a380x/src/systems/instruments/src/MFD/FMC/FmcAircraftInterface.ts
Thanks a lot! Just pushed the changes |
|
Quality Assurance Trainee Report Discord Username : spottersim Testing Process:
Testing Results: Negatives: Other observations: Conclusions: |
From the screenshots it looks like there's some minor other wrong things too.
Regarding the GW, the value displayed on the FUEL & LOAD page is not computed based on what is inserted on the page so it not changing seems reasonable. |
# Conflicts: # .github/CHANGELOG.md # fbw-a380x/src/systems/instruments/src/MFD/FMC/FlightManagementComputer.ts # fbw-a380x/src/systems/instruments/src/MFD/FMC/fmgc.ts # fbw-a380x/src/systems/instruments/src/MFD/MfdPageDirectory.tsx # fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFpln.tsx # fbw-a380x/src/systems/instruments/src/MFD/pages/common/FmsPage.tsx
|
@stratavelo92 Thanks a lot for the thorough test! Some of the issues you described weren't caused by this PR, so to keep the scope manageable I'd exclude them here. In scope for this PR (i.e. I will have a look): 4, 6, 8, 9 Out of scope (i.e. please create separate GitHub issues for these in order to track them): 7, 11, 12, 13, 14, 15, 16, 17 Not a bug: 10 |










Summary of Changes
Add SEC FPLN functionality to the A380X. WIP.
Only merge after #10005 .
Out of scope:
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.