Skip to content

Conversation

@BlueberryKing
Copy link
Member

@BlueberryKing BlueberryKing commented Dec 18, 2025

Fixes #[issue_no]

Summary of Changes

Fixes an issue where hold legs were displayed on the ND despite not being within 2 legs of the hold

Screenshots (if necessary)

Before:
image

After:
Screenshot 2025-12-16 130208

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Insert a hold into the flight plan, either active or secondary both should work the same. The hold is shown as a course reversal if the hold is not on the currently active leg.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@github-project-automation github-project-automation bot moved this to 🟡 Code Review: Ready for Review in Quality Assurance Dec 18, 2025
import { LnavConfig } from '../guidance/LnavConfig';

export class FlightPlanUtils {
public static getAllPathVectorsInFlightPlan(
Copy link
Member

@tracernz tracernz Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed to indicate that it's only returning the EFIS path vectors. But then, does it even belong in "FlightPlanUtils"? It's not really to do with flight planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🟡 Code Review: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants