-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(a32nx/sound): boris january sound fixes #10495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(a32nx/sound): boris january sound fixes #10495
Conversation
tracernz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCKs should go in large-files?
9e1f062 to
a176cff
Compare
Changed, should we also delete them from the main repo while at it? |
Yes, this PR should delete them and update the submodule ref. |
Done, and also updated with the latest files. |
|
LGTM. Once you’ve merged the large-files, you can update the submodule ref to the master commit there are then this can be approved. |
|
Quality Assurance Trainee Report Discord Username : adb_1872 Testing Process: Testing Results: Negatives: Conclusions: Media: |
|
Quality Assurance Trainee Report Discord Username : adb_1872 Testing Process: Testing Results: Negatives: Conclusions: Media: |
Fixes #[issue_no]
Summary of Changes
Small sound fixes from boris after the gpws sound update
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): bruno_pt99
Testing instructions
Check that the volume of the announcements is not too loud compared to master.
Check that the linked toilet flush sound issue does not play (https://discord.com/channels/738864299392630914/785976111875751956/1464002332306964592)
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.