Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Dec 27, 2025

jenkinsci/credentials-plugin#992

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja closed this Dec 27, 2025
@timja timja changed the title Test credentials cards PR again Test credentials wizard PR Jan 4, 2026
@timja timja reopened this Jan 4, 2026
@timja timja changed the title Test credentials wizard PR Adapt to New credentials dialog Jan 25, 2026
@timja timja marked this pull request as ready for review January 25, 2026 16:26
@timja timja requested a review from a team as a code owner January 25, 2026 16:26
@timja timja changed the title Adapt to New credentials dialog Adapt to New credentials dialog (don't merge) Jan 25, 2026
@timja
Copy link
Member Author

timja commented Jan 25, 2026

Ready for review but credentials plugin will need merging first: jenkinsci/credentials-plugin#992

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable, marking as draft to prevent accidental merging until we are ready

Comment on lines +781 to +786
<artifactItem>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>credentials</artifactId>
<version>1578.v4ea_f41d464ed</version>
<type>hpi</type>
</artifactItem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be reverted before merge

Suggested change
<artifactItem>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>credentials</artifactId>
<version>1578.v4ea_f41d464ed</version>
<type>hpi</type>
</artifactItem>

Comment on lines +504 to +507
<environmentVariables>
<!-- Use local version of the plugin over the released one ATH would otherwise use -->
<LOCAL_JARS>target/credentials.hpi</LOCAL_JARS>
</environmentVariables>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reverted before merge

Suggested change
<environmentVariables>
<!-- Use local version of the plugin over the released one ATH would otherwise use -->
<LOCAL_JARS>target/credentials.hpi</LOCAL_JARS>
</environmentVariables>

@jtnord jtnord marked this pull request as draft January 26, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants