Wait for 'Build Now' link visibility before clicking #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jenkins core race condition fix hides the 'Build Now' button
(display: none) until JavaScript loads. This caused ATH tests to
time out because clickLink('Build Now') couldn't find the hidden
element.
This fix adds waitFor(by.link('Build Now')) before clicking, which
polls until the element is visible (with ATH's default 120s timeout).
Fixes timeouts in:
- core.FreestyleJobTest.doNotDiscardSuccessfulBuilds
- core.FreestyleJobTest.archiveArtifacts
- core.TriggerRemoteBuildsTest.triggerBuildRemotely
jtnord
reviewed
Jan 20, 2026
Comment on lines
+365
to
+366
| // Wait for "Build Now" link to become visible (JS shows it after page load) | ||
| waitFor(by.link("Build Now")); |
Member
There was a problem hiding this comment.
Are you sure this fixes the issue, as this is looking for a a element with the text Build Now and IIUC the upstream change does not change that.
In essence I think this is just wasting some CPU such that the timing changes enough that clicking the link works.
Additionally if you do need to wait and then interact with the thing you waited for then use the WebElement returned by waitFor
timja
reviewed
Jan 20, 2026
| int nb = getJson().get("nextBuildNumber").intValue(); | ||
| if (parameters.isEmpty()) { | ||
| // Wait for "Build Now" link to become visible (JS shows it after page load) | ||
| waitFor(by.link("Build Now")); |
Member
There was a problem hiding this comment.
I'm not sure that this would work, please test this in your PR in the jenkins repository using an incremental build when the tests here pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jenkins core race condition fix hides the 'Build Now' button (display: none) until JavaScript loads. This caused ATH tests to time out because clickLink('Build Now') couldn't find the hidden element.
This fix adds
waitFor(by.link('Build Now'))before clicking, which polls until the element is visible (with ATH's default 120s timeout).Fixes timeouts in:
Testing done
The fix was tested by reviewing the CI failure logs which showed all 3 tests failing at
Job.scheduleBuild(Job.java:368)when callingclickLink("Build Now"). The tests timed out after 120 seconds waiting for an element that was hidden.The
waitFor(by.link("Build Now"))method polls until the element becomes visible, using ATH's existing wait infrastructure. This is the same pattern already used elsewhere in the codebase (e.g., the notification-bar wait on the following line).Related upstream change: jenkinsci/jenkins#26124 (Jenkins core race condition fix)
Submitter checklist
Desired revierwe
@timja @mawinter69 @MarkEWaite