Directly view existing explanation #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking on the "Explain Error" button when viewing the console output and an explanation already exists a intermediate pseudo dialog was shown to either show the explanation, regenerate or cancel. I think that is not a good UI experience. An existing explanation is now directly shown when clicking in "Explain Error". The card now has 2 buttons in the top right that allow to regenerate and to close the explanation.
shenxianpeng
added
the
enhancement
6 tasks
shenxianpeng
added a commit
that referenced
this pull request
Nov 13, 2025
fixup of #57 ### Testing done <!-- Comment: Provide a clear description of how this change was tested. At minimum this should include proof that a computer has executed the changed lines. Ideally this should include an automated test or an explanation as to why this change has no tests. Note that automated test coverage is less than complete, so a successful PR build does not necessarily imply that a computer has executed the changed lines. If automated test coverage does not exist for the lines you are changing, you must describe the scenario(s) in which you manually tested the change. For frontend changes, include screenshots of the relevant page(s) before and after the change. For refactoring and code cleanup changes, exercise the code before and after the change and verify the behavior remains the same. --> ### Submitter checklist - [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch! - [x] Ensure that the pull request title represents the desired changelog entry - [x] Please describe what you did - [ ] Link to relevant issues in GitHub or Jira - [x] Link to relevant pull requests, esp. upstream and downstream changes - [ ] Ensure you have provided tests that demonstrate the feature works or the issue is fixed <!-- Put an `x` into the [ ] to show you have filled the information. The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on the "Explain Error" button when viewing the console output and an explanation already exists a intermediate pseudo dialog was shown to either show the explanation, regenerate or cancel. I think that is not a good UI experience.
An existing explanation is now directly shown when clicking in "Explain Error". The card now has 2 buttons in the top right that allow to regenerate and to close the explanation.
Even when the explainer is disabled after an explanation has been created for a run, the button will be available. But re-explaining will not be available in that case.
The change also prevents that the footer injects anything to a page or loads the js when not on a console url.
fixes #52
After:
Testing done
Interactive testing and added unit tests that ensure the div is properly injected.
Submitter checklist