Skip to content

Conversation

@lchudinov
Copy link
Contributor

@lchudinov lchudinov commented Jan 29, 2026

[graphql] Migrate GraphQL Extension to type-graphql v2.0.0-rc.2

The GraphQL extension currently uses type-graphql version 2.0.0-beta.2.
This PR migrates the extension to the latest release candidate, 2.0.0-rc.2.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Affected example projects in examples/* were updated

@lchudinov lchudinov changed the title feat(graphql): migrate to type-graphql 2.0.0-rc.2 draft: feat(graphql): migrate to type-graphql 2.0.0-rc.2 Jan 29, 2026
@lchudinov lchudinov force-pushed the feature/migrate-graphql-extension-to-type-graphql-2-0-0-rc-2 branch 4 times, most recently from 2ee0850 to 0a104fb Compare January 29, 2026 11:59
@coveralls
Copy link

coveralls commented Jan 29, 2026

Pull Request Test Coverage Report for Build 21503617287

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 54.843%

Totals Coverage Status
Change from base Build 21489675365: -0.004%
Covered Lines: 9572
Relevant Lines: 12457

💛 - Coveralls

@lchudinov lchudinov changed the title draft: feat(graphql): migrate to type-graphql 2.0.0-rc.2 feat(graphql): migrate to type-graphql 2.0.0-rc.2 Jan 29, 2026
@lchudinov lchudinov force-pushed the feature/migrate-graphql-extension-to-type-graphql-2-0-0-rc-2 branch from 0a104fb to 4f9291c Compare January 30, 2026 03:39
@lchudinov lchudinov force-pushed the feature/migrate-graphql-extension-to-type-graphql-2-0-0-rc-2 branch from 4f9291c to 0885dfe Compare January 30, 2026 03:44
@lchudinov
Copy link
Contributor Author

Hi @dhmlau, Could you please review this PR?

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lchudinov, thanks for the PR. The changes look reasonable to me. I'm not familiar with this extension, so it would be ideal to have at least one more review before we land this PR.

Also, I have a question about one file. Thanks.

@@ -1,6 +1,6 @@
// Copyright IBM Corp. 2020. All Rights Reserved.
// Copyright ACME Inc. 2020,2026. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change? Is it generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants