[0.81]Visual studio 2026 strict check fix #15602
Open
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HariniMalothu17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vissual Studio 2026’s stricter compiler/static-analysis settings started treating “assignment inside conditionals” as errors (not just warnings). The change rewrites patterns like if (p = get()) into a separate assignment followed by a boolean check to satisfy strict checks of Visual Studio 2026
Type of Change
Why
To make rnw 0.81 compatible with vs2026
What
The commit updates conditional-assignment sites in:
[UiaHelpers.cpp]
[queueService.cpp]
[uiScheduler_winrt.cpp]
[OriginPolicyHttpFilter.cpp]
Screenshots
Testing
Tested via playground.Working as expected
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow