Item template expansion - Table Valued functions #21008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21008 +/- ##
==========================================
- Coverage 66.87% 66.87% -0.01%
==========================================
Files 219 219
Lines 21014 21014
Branches 2758 2758
==========================================
- Hits 14054 14053 -1
Misses 6857 6857
- Partials 103 104 +1 🚀 New features to boost your workflow:
|
ssreerama
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez and
manujoseph85
as code owners
| @@ -0,0 +1,16 @@ | |||
| CREATE FUNCTION [@@SCHEMA_NAME@@].[@@OBJECT_NAME@@] | |||
Contributor
There was a problem hiding this comment.
Just curious, but why do we need a template?
Contributor
Author
There was a problem hiding this comment.
Template files allow us to add consistent, predefined SQL object stubs and update or expand templates over time without code changes, while keeping object placement and rules in code.
lewis-sanchez
previously approved these changes
Jan 26, 2026
ssreerama
dismissed
lewis-sanchez’s stale review
The base branch was changed.
| // Test edge case: leading dot | ||
| result = projController.parseSchemaAndObjectName('.MyFunction'); | ||
| expect(result.schemaName, 'Leading dot should not be treated as schema').to.equal('dbo'); | ||
| expect(result.objectName, 'Full string should be the object name').to.equal('.MyFunction'); |
Contributor
There was a problem hiding this comment.
The dot becomes part of the object name?
Contributor
Author
There was a problem hiding this comment.
yes, we do allow special characters in the name
lewis-sanchez
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
This Pr adds:
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines