feat: provide de-duplicated secondary resources stream on Context #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
…tor/api/reconciler/ReconcileUtils.java Co-authored-by: Martin Stefanko <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
metacosm
requested review from
csviri and
xstefank
and removed request for
xstefank
Alternative without requiring collecting to a Map Signed-off-by: Chris Laprun <[email protected]>
openshift-merge-robot
removed
the
needs-rebase
xstefank
approved these changes
Jan 30, 2026
...-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/DefaultContext.java
Show resolved
Hide resolved
...-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/DefaultContext.java
Show resolved
Hide resolved
| * @param <T> the type of HasMetadata objects | ||
| * @return a collector that produces a collection of deduplicated Kubernetes objects | ||
| */ | ||
| public static <T extends HasMetadata> Collector<T, ?, Collection<T>> latestDistinct() { |
Collaborator
There was a problem hiding this comment.
wasn't this moved to ReconcileUtilsInternal
Collaborator
Author
There was a problem hiding this comment.
If we were to keep this implementation, this actually would be removed
csviri
requested changes
Jan 30, 2026
Collaborator
csviri
left a comment
csviri
left a comment
There was a problem hiding this comment.
Made some minor comments, pls add unit tests! Otherwise looks great, thank you!!
|
|
||
| default <R> Stream<R> getSecondaryResourcesAsStream(Class<R> expectedType) { | ||
| return getSecondaryResources(expectedType).stream(); | ||
| return getSecondaryResourcesAsStream(expectedType, false); |
Collaborator
There was a problem hiding this comment.
Here we could use the former implementation and call this in case in the new method the deduplication is false.
...-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/DefaultContext.java
Show resolved
Hide resolved
| return controller.getEventSourceManager().getEventSourcesFor(expectedType).stream() | ||
| .map(es -> es.getSecondaryResources(primaryResource)) | ||
| .flatMap(Set::stream); | ||
| public <R> Stream<R> getSecondaryResourcesAsStream(Class<R> expectedType, boolean deduplicate) { |
Collaborator
There was a problem hiding this comment.
Please add comprehensive javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3130, to discuss