CI improvement [2] #193
Open
CI improvement [2] #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_data.js
The store() function now returns { cid, blockHash, blockNumber } instead of
just the CID. Update the destructuring to extract the cid property correctly.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace the simple "Number of blocks" metric with a detailed breakdown showing the transaction count for each block in the measured range, including a visual bar chart for quick distribution analysis. Co-Authored-By: Claude Opus 4.5 <[email protected]>
x3c41a
commented
Jan 27, 2026
Replace hardcoded value with configurable constant set to 16. Co-Authored-By: Claude Opus 4.5 <[email protected]>
bkontur
reviewed
Jan 28, 2026
examples/justfile
Outdated
Comment on lines
626
to
628
| # ipfs_api_url - IPFS API URL (default: http://127.0.0.1:5001 for local Docker Kubo) | ||
| run-tests-against-westend seed ipfs_api_url="http://127.0.0.1:5001": | ||
| just run-tests-against "wss://westend-bulletin-rpc.polkadot.io" "{{ seed }}" "{{ ipfs_api_url }}" |
Collaborator
There was a problem hiding this comment.
@x3c41a please also add this for Paseo here - we have the WS url
Contributor
Author
There was a problem hiding this comment.
shall I just parametrise this function? e.g. run-tests-against-live-chain <network> <seed> <ipfs_api_url>?
bkontur
reviewed
Jan 28, 2026
Calculate startBlock and endBlock from the first and last blocks where transactions were actually included, rather than querying the current block number at start/end times. Also show all blocks (including empty ones) in the TRANSACTIONS PER BLOCK section, displaying 0 txs for blocks without transactions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Wait for finalized blocks in authorizePreimage and authorizeAccount calls to ensure authorization is complete before proceeding with store. Co-Authored-By: Claude Opus 4.5 <[email protected]>
bkontur
reviewed
Jan 29, 2026
…l size would not pass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network_addressandprivate_key. Propagated those parameters throughjust,store_big_data.js,justfileunderrun-tests-againstfunction,Closes #174