Mark more things as literals #20604
Open
Mark more things as literals #20604
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
cdce8p
reviewed
Jan 17, 2026
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
reviewed
Jan 30, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Does this have any behavior change? If yes, consider adding a test case.
| Key: _TypeAlias = tuple[Any, ...] | ||
| LITERAL_NAMES = frozenset( | ||
| ("builtins.True", "builtins.False", "builtins.None", "builtins.NotImplemented") | ||
| ) |
Collaborator
There was a problem hiding this comment.
As micro-optimization, can you make this Final? This is potentially perfomance-critical, and Final will make lookups faster when using mypyc.
| if e.fullname in LITERAL_NAMES: | ||
| return LITERAL_YES | ||
| elif isinstance(e.node, TypeAlias) and not e.node.python_3_12_type_alias: | ||
| if is_named_instance(e.node.target, LITERAL_NAMES): |
Collaborator
There was a problem hiding this comment.
Can a type alias refer to anything but None out of the options here? If this is case, maybe avoid LITERAL_NAMES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #20492. This is basically just refactoring based on what seems more correct.